![]() It uses the built-in phy and runs Kernel 3.0.35 and IGB driver 5.0.6. ![]() ![]() System A has an I210 (WGI210AT) connected over PCIe to the i.MX6. System B brings up the ethernet interface but never establishes link (100 or 1Gbit), and the loopback/offline test fails: System A works fine, establishes link and passes the loopback/offline test. 6:57 ` Jamaluddin, Aminuddin 0 siblings, 1 reply 7+ messages in threadI have two custom ARM i.MX6 I210 systems, A and B. 7:51 ` Jamaluddin, Aminuddin 12:17 ` Andrew Lunn * Re: net: phy: marvell: add link status check before enabling phy loopback > The kernel seems to be pretty consistent in having loopback as one word. > I'm just trying to ensure we don't end up here with -ETIMEDOUT. Yes we have and its expected to have the timeout. > Have you tested this with the cable unplugged? Its required cabled plug in, back to back connection. > + err = phy_read_poll_timeout(phydev, MII_BMSR, > - /* FIXME: Based on trial and error test, it seem 1G need to > Subject: Re: net: phy: marvell: add link status check before Linux-kernel, stable, Tan, Tee Min, Zulkifli, Muhammad Husaini Jakub Kicinski, Paolo Abeni, Ismail, Mohammad Athari, netdev, ![]() 12:17 ` Andrew Lunn 0 siblings, 1 reply 7+ messages in threadįrom: Jamaluddin, Aminuddin 7:51 UTC ( / raw)Ĭc: Heiner Kallweit, Russell King, David S. 13:26 ` Andrew Lunn 7:51 ` Jamaluddin, Aminuddin * RE: net: phy: marvell: add link status check before enabling phy loopback The kernel seems to be pretty consistent in having loopback as one I'm just trying to ensure we don't end up here with -ETIMEDOUT. Have you tested this with the cable unplugged? > + err = phy_read_poll_timeout(phydev, MII_BMSR, val, val & BMSR_LSTATUS, > - * delay between soft reset and loopback enablement. > - /* FIXME: Based on trial and error test, it seem 1G need to have If (err -2015,14 +2016,23 static int m88e1510_loopback(struct phy_device *phydev, bool enable) + /* It takes some time for PHY device to switchĮrr = phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, 0) + err = phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, return phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, + err = phy_read_poll_timeout(phydev, MII_BMSR, val, val & BMSR_LSTATUS, +++ -1992,6 +1992,7 static int m88e1510_loopback(struct phy_device *phydev, bool enable)īmcr_ctl = mii_bmcr_encode_fixed(phydev->speed, -2015,14 +2016,23 static int m88e1510_loopback(struct phy_device *phydev, bool enable) Signed-off-by: Muhammad Husaini Zulkifli ĭrivers/net/phy/marvell.c | 22 ++++++++++++++++-Ģ files changed, 19 insertions(+), 6 deletions(-)ĭiff -git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c This is needed to ensure the stability and consistency when runningįixes: 020a45aff119 ("net: phy: marvell: add Marvell specific PHY loopback") , aminuddin.jamaluddinĪdd link status checking in m88e1510_loopback() for 1Gbps link speedĪnd delay for 100ms after phy loopback bit is set before send packet. Miller,Įric Dumazet, Jakub Kicinski, Paolo Abeni,Ĭc: netdev, linux-kernel, stable, , To: Andrew Lunn, Heiner Kallweit, Russell King, David S. 13:26 ` Andrew Lunn 0 siblings, 1 reply 7+ messages in threadįrom: Aminuddin Jamaluddin 8:22 UTC ( / raw) Net: phy: marvell: add link status check before enabling phy loopback archive mirror help / color / mirror / Atom feed * net: phy: marvell: add link status check before enabling phy loopback 8:22 Aminuddin Jamaluddin
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |